Defer package summaries until cleanup - #23552
Merged
Merged
Conversation
Contributor
|
Thanks for your pull request. This has been closed because it appears to be missing the pull request template, perhaps because this was written by an AI not a human. We require humans to read and fill in these templates. Please edit this pull request to fill in the current pull request template. This workflow will reopen this pull request automatically once the template is complete. Do not open a new pull request for this. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures brew install/reinstall/upgrade end-of-run output so formula/cask caveats are collected during installation and displayed once after cleanup, including before the final upgrade summary.
Changes:
- Add
Homebrew::Install.finish_installationto centralize install cleanup + message finalization across commands. - Stop printing formula/cask caveats inline during installation; record them for deferred display via
Homebrew.messages. - Update command specs to assert the new cleanup → caveats/message ordering and new
display_messagesparameters.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/install.rb | Adds finish_installation helper to run cleanup and display deferred messages/caveats. |
| Library/Homebrew/formula_installer.rb | Switches formula caveats handling from inline printing to recording for deferred display. |
| Library/Homebrew/cask/installer.rb | Stops inline caveats printing during cask install by no longer printing the returned caveats string. |
| Library/Homebrew/cask/upgrade.rb | Stops inline caveats printing during cask upgrade by no longer printing the returned caveats string. |
| Library/Homebrew/cmd/install.rb | Uses Install.finish_installation instead of inlining cleanup/message display. |
| Library/Homebrew/cmd/reinstall.rb | Uses Install.finish_installation and removes now-redundant requires. |
| Library/Homebrew/cmd/upgrade.rb | Uses Install.finish_installation so caveats/messages print before the final upgrade summary. |
| Library/Homebrew/test/install_spec.rb | Adds coverage for finish_installation ordering (cleanup before message display). |
| Library/Homebrew/test/formula_installer_spec.rb | Adds coverage ensuring formula caveats are recorded without inline stdout output. |
| Library/Homebrew/test/cask/installer_spec.rb | Updates expectation to record cask caveats without inline stdout output. |
| Library/Homebrew/test/cmd/install_spec.rb | Updates command expectations for deferred caveats display via force_caveats. |
| Library/Homebrew/test/cmd/reinstall_spec.rb | Updates command expectations for deferred caveats display via force_caveats. |
| Library/Homebrew/test/cmd/upgrade_spec.rb | Updates command expectations for deferred caveats display via force_caveats. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MikeMcQuaid
force-pushed
the
consistent-install-flow
branch
from
August 17, 2026 19:24
227d58b to
2c37773
Compare
MikeMcQuaid
force-pushed
the
consistent-install-flow
branch
2 times, most recently
from
August 18, 2026 10:23
8fe7695 to
9149c17
Compare
p-linnane
approved these changes
Aug 18, 2026
MikeMcQuaid
force-pushed
the
consistent-install-flow
branch
from
August 18, 2026 16:31
9149c17 to
08bd988
Compare
- collect formula and cask caveats without inline output - share cleanup and message finalisation across commands - print one caveat summary before the final upgrade result
MikeMcQuaid
force-pushed
the
consistent-install-flow
branch
from
August 18, 2026 18:23
08bd988 to
dc0ed6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 GPT Sol xhigh with local review and testing.